-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve the accuracy of docs/improve docs #4845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Sep 23, 2020
vladfrangu
requested changes
Sep 24, 2020
kyranet
approved these changes
Oct 12, 2020
vladfrangu
approved these changes
Oct 12, 2020
SpaceEEC
approved these changes
Oct 13, 2020
iCrawl
approved these changes
Oct 17, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Noel <icrawltogo@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR changes some code to
?Type
which indicates nullable but were being set toundefined
, they are now set to nullGuild#voice
)@name
tags from certian declarations, they are only needed if the typedef is not directly above the actual declaration@prop
tags to@property
for consistency@abstract
tag on them, as they are abstract classesthis PR is a breaking change
Status
null
causes any internal problems with the library (eg `typeof x === 'undefined'), will get round to itSemantic versioning classification: